Skip to content

add zizmor security GH action#754

Merged
JessicaS11 merged 2 commits intodevelopmentfrom
security
Apr 21, 2026
Merged

add zizmor security GH action#754
JessicaS11 merged 2 commits intodevelopmentfrom
security

Conversation

@JessicaS11
Copy link
Copy Markdown
Member

@JessicaS11 JessicaS11 commented Apr 15, 2026

Thanks to @mfisher87 for creating this workflow for earthaccess and pointing me towards it to enhance our GitHub action security.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026 •
edited
Loading

Binder 👈 Launch a binder notebook on this branch for commit b09deef

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 620b454

@github-advanced-security
Copy link
Copy Markdown

github-advanced-security AI commented Apr 15, 2026

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.22%. Comparing base (86ab52a) to head (620b454).
⚠️ Report is 1 commits behind head on development.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #754      +/-   ##
===============================================
- Coverage        77.34%   77.22%   -0.13%     
===============================================
  Files               42       42              
  Lines             3231     3231              
  Branches           401      401              
===============================================
- Hits              2499     2495       -4     
- Misses             600      603       +3     
- Partials           132      133       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

weiji14
weiji14 reviewed Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jessica, I've secretly used Zizmor at 3e1d75c to fix some issues already, but there are some remaining. Would you like to apply some more fixes directly in this PR, or in a follow-up PR? Happy to push those changes if you'd like.

Comment thread .github/workflows/zizmor.yml
Comment thread .github/workflows/zizmor.yml
Copy link
Copy Markdown
Member

@weiji14 weiji14 Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could probably combine this zizmor job into linter_actions.yml to reduce the number of GH Actions files, but up to you!

Copy link
Copy Markdown
Member

@mfisher87 mfisher87 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer shorter files or I end up struggling to find stuff, but that's just me, and this repo shouldn't be optimized for me 😁

@mfisher87 mfisher87 changed the title add zizmore security GH action add zizmor security GH action Apr 17, 2026
@mfisher87 @weiji14
Add dependabot path to workflow trigger
620b454 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@JessicaS11
Copy link
Copy Markdown
Member Author

JessicaS11 commented Apr 21, 2026

Thanks Jessica, I've secretly used Zizmor at 3e1d75c to fix some issues already, but there are some remaining. Would you like to apply some more fixes directly in this PR, or in a follow-up PR? Happy to push those changes if you'd like.

Awesome! If you've got those changes handy I would so appreciate you pushing them (to a new branch/PR).

@JessicaS11 JessicaS11 merged commit c64eaa1 into development Apr 21, 2026
12 of 14 checks passed
@JessicaS11 JessicaS11 deleted the security branch April 21, 2026 15:33
@weiji14 weiji14 mentioned this pull request Apr 22, 2026
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 left review comments

@mfisher87 mfisher87 mfisher87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JessicaS11 @github-advanced-security @mfisher87 @weiji14